Feature Branch Exit Criteria
The following criteria must be met before considering landing the feature branch into master.
Exit Criteria | Status/Notes |
---|---|
Test automation and CI is 100% complete with “required for version” | |
No defects with high/critical exposure or “required for version” | |
|
Initial merge will have scrubbing disabled by default, so felt full daily/weekly not necessary in favor of feature specific testing. All PR tests passed on latest version with checksum Features specified. |
All tests are passing for feature in weekly and daily regression tests |
|
Performance and scale testing executed according to test plan/required requirements. Results are reviewed and approved |
I’ve done some initial performance testing with some local changes. No noticeable performance impact with “lazy” mode. After these changes have landed need to do more official performance testing. Should have no impact with when disabled. |
SDL Code scans are competed (Coverity, Bandit, Checkmarx, Snyk). For all scans, all issues have been dispositioned, and the issues that are required per SDL rules have been fixed. |
- There’s not currently a way to run Coverity on feature branches, but David Quigley (Deactivated) said that he can do what sounds like an ad hoc scan. |
SAFE review executed if required | SAFE review is not needed. |
Any new dependencies identified and Oked by ESAD OSPDT owner | No new dependencies |
Does not regress endurance testing from current master baseline with feature enabled |
|
Does not regress scale testing from current master baseline with feature enabled |
|
Manual test plans and “out-of-box experience” testing are 100% executed with “required for version”. Manual test results are recorded | All tests should be automated |
Feature branch is up to date with master |
|
Feature Completion Criteria
The following criteria must be met before considering the feature is complete
Exit Criteria | Status/Notes |
---|---|
Requirements are defined in SRS Jira Project | |
Design document is complete, reviewed, and approved utilizing the team template | /wiki/spaces/DAOS/pages/11052974081 has been reviewed. |
Test plan for feature is complete, reviewed, and approved utilizing the team template. Security validate plan is also updated if applicable. | |
Planned software feature is 100% implemented with “required for version” | |
All user documentation updated and reviewed (e.g., admin guide, user guide) | |
Code coverage results have been reviewed to identify gaps in testing, and test plan has been updated and executed accordingly. Functional and branch coverage each are equivalent or better than master | |
Usability is evaluated and results are reviewed | Not sure what the process is for evaluating “usability” |